-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy-imports not happy with class self referencing it via type hints (PyInf#12204) #318
Comments
dshivashankar1994
changed the title
tidy-imports not happy with class self referencing it via type hints
tidy-imports not happy with class self referencing it via type hints (PyInf#12204)
Mar 12, 2024
Carreau
added a commit
to Carreau/pyflyby
that referenced
this issue
Mar 18, 2024
This adds a failing test.
Carreau
added a commit
to Carreau/pyflyby
that referenced
this issue
Mar 18, 2024
Carreau
added a commit
to Carreau/pyflyby
that referenced
this issue
Mar 18, 2024
Carreau
added a commit
to Carreau/pyflyby
that referenced
this issue
Mar 18, 2024
Carreau
added a commit
that referenced
this issue
Mar 19, 2024
This adds failing test, cleanup and fix for #318 (incorrect import insert due to improper stack count)
This should be closed by #320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a class is added in pyflyby global imports and in the class defn itself if the class is referenced via type-hints, tidy-imports wrongly suggests to add the import.
Reproducer:
But the same type hints doesn't suggest for imports if the extra class is not present but the type-hints exist.
The text was updated successfully, but these errors were encountered: