This adds failing test, cleanup and fix for #318 (incorrect import insert due to improper stack count) #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
changed the title
Carreau
force-pushed
the
weird-types
branch
3 times, most recently
from
e730a16 to
efc8cab
Compare
|
Closes #318 |
This was triggering negative number of class scopes, and not allowing proper scoping of type annotations in class definitions. It is still weird that this work before unhiding the class scope, but I guess as we are in Function Scope this is going to be a delayed evaluation of the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that one need to have the conflicting import in the ImportDB.
I still need to track down and check what are the proper scopes.