Handle cells magics + tidy-imports on notebook #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following - 1. Ignore the cells which have magic commands 2. Removing new-lines created by when imports are extracted 3. Apply import formatting to the final extracted imports
mlucool
approved these changes
Feb 16, 2024
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 68.13% 68.09% -0.04%
==========================================
Files 25 25
Lines 7975 7978 +3
==========================================
- Hits 5434 5433 -1
- Misses 2541 2545 +4 ☔ View full report in Codecov by Sentry. |
dshivashankar1994
pushed a commit
that referenced
this pull request
Feb 20, 2024
This PR does the following - 1. Ignore the cells which have magic commands 2. Removing new-lines created by when imports are extracted 3. Apply import formatting to the final extracted imports (cherry picked from commit d56dde1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following -