Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Python 312. #314

Merged
merged 7 commits into from
May 20, 2024
Merged

Compatibility with Python 312. #314

merged 7 commits into from
May 20, 2024

Conversation

Carreau
Copy link
Collaborator

@Carreau Carreau commented Mar 4, 2024

This starts looking into compatibiliy with Python 3.12.

There seem to have been a number of changes to the bytecode in 3.12, following a number of changes in 3.11 as well, and 3.13 also adds a bunch.

It seem though that the dis module has gained a number of convenience classes and methods, in particular dis.Bytecode. I think in a couple of places it might be worth looking into using that instead of parsing the bytecode ourselves.

There are  few changes in bytecode, including a few documented changes
that are not actually present.
Carreau added 5 commits May 20, 2024 13:40
The enum now show their value in 3.12,
and the docstring fo sys.std.write has had minor modifications.

I will also note that I swapped the `expected == result`  for `result ==
expected` in all the file so that the diff when failing is easier to
read.
@Carreau Carreau marked this pull request as ready for review May 20, 2024 12:56
@Carreau Carreau merged commit d7e0011 into deshaw:master May 20, 2024
8 checks passed
@Carreau Carreau changed the title Draft: Compatibility with Python 312. Compatibility with Python 312. May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant