Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates and types annotations + unused parameter deprecation #319

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Misc updates and types annotations + unused parameter deprecation #319

merged 5 commits into from
Mar 18, 2024

Conversation

Carreau
Copy link
Collaborator

@Carreau Carreau commented Mar 18, 2024

This does a few things:

  • Rename cached property to avoid static typing error, despite the aliasing, some tools still don't like it
  • Add is_comment and is_blank for PythonStatement this will be useful for import sorting.
  • deprecate unused assume_contiguous kwarg
  • some Filetext typing information to decrease static typing IDE noise.

Carreau added 5 commits March 18, 2024 10:39
@Carreau
Rename cached property to avoid static typing error
f7c58a0 
Despite the aliasing, some tools still don't like it
@Carreau
Add is_comment and is_blank for PythonStatement
24f5f49 
Also add some typing information to help.

This will be useful to implement the sorting logic we want to implement
@Carreau
deprecate unused assume contiguous
97f9806
@Carreau
fix asc
54390ad
@Carreau
some Filetext typing
9e36999
@Carreau Carreau merged commit b000193 into deshaw:master Mar 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Carreau