Qsocat qn columns #144
Open
Qsocat qn columns #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanagreen
approved these changes
Nov 12, 2024
| @@ -580,7 +603,8 @@ def build_qso_catalog_from_healpix(redux='/global/cfs/cdirs/desi/spectro/redux/' | |||
| * dir_output (str): directory where the QSO catalog will be saved. | |||
| * npool (int): nbr of workers used for the parallelisation. | |||
| * keep_qso_targets (bool): if True save only QSO targets. default=True | |||
| * keep_all (bool): if True return all the targets. if False return only targets which are selected as QSO. default=False | |||
| * keep_all (bool): if True return all the targets. if False return only targets which are selected as QSO. default=Falsei | |||
There was a problem hiding this comment.
Accidental spurious i char at the end of this line
|
I realized I checked this branch against loa v0 of the QSO catalogs, not v1. When making the correct comparison, only changes come from the ZWARN column for 1.4% of the catalog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ZWARN column for QN-identified QSOs with new Redrock redshifts. Previously only the Z, ZERR columns were updated for these objects, meaning the ZWARN value was set from the initial Redrock run.
This PR follows desispec #2407, which extended the list of saved attributes from the QN informed redrock rerun to include ZWARN. Backward compatibility is maintained with the update_qn_zwarn argument.
I verified
update_qn_zwarn=Falseandupdate_qn_zwarn=Truegive identical catalogs aside from the zwarn column in ~1%. Comparing to the existing healpix Loa catalog, I found changes for Z, ZERR, ZWARN. The Z/ZERR changes are limited to 1.4<z<1.6 where I believe we expect some shuffling from updates to the QN afterburner script.Test catalog with default
update_qn_zwarn=Truehere:/global/cfs/cdirs/desi/users/abrodze/test_qsocat/QSO_cat_loa_main_dark_healpix_test.fits@dylanagreen please check that things look right.