Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIBERSTATUS bits for VARIABLETHUR and NEARCHARGETRAP #2304

Closed
5 tasks done
sbailey opened this issue Jul 23, 2024 · 4 comments
Closed
5 tasks done

Add FIBERSTATUS bits for VARIABLETHUR and NEARCHARGETRAP #2304

sbailey opened this issue Jul 23, 2024 · 4 comments
Assignees

Comments

@sbailey
Copy link
Contributor

sbailey commented Jul 23, 2024

Several tasks for adding new non-fatal but problematic bits to FIBERSTATUS:

In the future there may be additional FIBERSTATUS bits for cases like this; problematic but not fatal.

@julienguy
Copy link
Contributor

@julienguy
Copy link
Contributor

Added NEARCHARGETRAPFIBERS: 3969 to some configs of $DESI_SPECTRO_CALIB/spec/sm8/sm8-z.yaml . Tested with assemble_fibermap(night=20240213, expid=225329).

@julienguy
Copy link
Contributor

Added VARIABLETHRUFIBERS: 4891 to $DESI_SPECTRO_CALIB/spec/sm3/sm3-b.yaml (equivalent to editing any other camera), which is a fiber we will probably never fully recover (see issue #2305). I am waiting for the end of the study on improvements to the TPCORR parameters before flagging other fibers.

@sbailey sbailey changed the title Add FIBERSTATUS bits for TPCORR_UNSTABLE and CTE_EDGE Add FIBERSTATUS bits for VARIABLETHUR and NEARCHARGETRAP Aug 20, 2024
@sbailey
Copy link
Contributor Author

sbailey commented Aug 20, 2024

Bits have been added to both the code and desi_spectro_calib yaml files. In the end we have been fairly conservative for when to set the bit so that we don't over-mask. Even if NEARCHARGETRAP is strictly informative, many users instinctively require FIBERSTATUS=0 and would discard mostly ok spectra, so we only set it for the worse cases.

@sbailey sbailey closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants