FIBERSTATUS VARIABLETHRU bad for sky and stdstars #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FIBERSTATUS bit VARIABLETHRU to the mask of bad bits that should not be used for sky fibers and standard stars.
Most of the changes here are adding comments and unit tests to confirm current behavior; excluding VARIABLETHRU for sky and stdstars is the only functional change here.
After discussing with @julienguy, we decided to treat NEARCHARGETRAP as strictly informative and not exclude it from sky fibers since it is actually a per-AMP problem, not a per-FIBER problem, but we don't structurally have a way to encode that.
Related to #2304.