Kibo dropped TSNR2_LYA and TSNR2_QSO columns

[sbailey]

Compared to Iron, kibo/zcatalog/v1/zpix-all-kibo.fits has dropped the columns TSNR2_LYA and TSNR2_QSO, though it retains the per-camera values TSNR2_LYA_[BRZ] and TSNR2_QSO_[BRZ]. Track down if this is a bug or a purposeful choice that we forgot about.

Thanks to @stephjuneau for reporting.

[sbailey]

Update: Those columns are present in the ztile*.fits and zpix*.fits files, but are being dropped by desispec.zcatalog.update_table_columns when it is trying to standardize the order of the columns across input files. It is incorrectly assuming that TSNR2_LRG is the last of the TSNR2 columns, which for some reason changed in Kibo compared to Iron.

[sbailey]

Fixed by PR #2368