desi_zcatalog --recoadd-fibermap option #2109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2087 by adding a
desi_zcatalog --recoadd-fibermap
option to recoadd the spectra FIBERMAP -> FIBERMAP, EXP_FIBERMAP instead of propagating the previously coadded versions from the redrock files. This enables us to rebuild the stacked redshift catalogs while bringing in the bug fixes from e.g. PRs #2100 (IN_COADD_B/R/Z), #2094 (target bit bitwise OR), and #2093 (COADD_FIBERSTATUS bug fixes).A companion option
--ztile
flags whether this is a tile-based coadd (vs. a healpix based coadd). I plan a separate PR to simplify thedesi_zcatalog
options and this might change again, but I've tried to focus this PR on the minimal changes needed to support adding re-coadding.One non-minimal change for simplicity is dropping support for the "ZBEST" HDU (renamed "REDSHIFTS") and dropping support for missing TSNR2 and EXP_FIBERMAP; all of these cases were for internal releases that pre-date Fuji/EDR.