Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor PR: add option bin/desi_average_flux_calibration #2127

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

julienguy
Copy link
Contributor

This is really a tiny difference that does not affect the pipeline:
Add option to desi_average_flux_calibration to remove flatfield correction.

@sbailey
Copy link
Contributor

sbailey commented Oct 9, 2023

Looks good, but I made two small changes:

  • use desispec.io.util.replace_prefix instead of filename.replace(...). Simply using replace breaks if you have a specprod with a name like "test-fluxcalib" (we've encountered variants of this problem multiple times with other filename manipulation, thus the existence of replace_prefix to replace only the filename prefix and not any other places where it appears in the path or filename)
  • print -> log.info

Since I don't know example inputs to test this, please retry this branch with your work to make sure I didn't introduce a typo, then ok to merge.

@julienguy
Copy link
Contributor Author

I checked your change. Thanks.

@julienguy julienguy merged commit 8de794d into main Oct 9, 2023
24 checks passed
@sbailey sbailey deleted the average-flux-calibration branch January 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants