Fix pernight bug and remove desi_run_night script #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #2338 with a simple two-line fix. I tested it with
dry_run_level=1on two separate nights, which were both successful. Those tests should provide full coverage for the generation of a processing table row. The code no longer crashes when requesting pernight redshifts, and the pernight job rows have unique internal ID's and the correct metadata.This PR also removes the desi_run_night but not the underlying Python code, just in case we want to bring it back in the future (though that is unlikely). This will prevent people from using it accidentally instead of the new and similarly named
desi_proc_night.