cross-tile spectra stack header cleanup #2340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bookkeeping cleanup PR for
desispec.spectra.stack
for the case of stacking multiple tile-based spectra across different tiles. Previously this case generates a bunch of warnings like:and it incorrectly propagated per-tile keywords from the first spectra object. This PR detects the multi-tile case and removes the per-tile keywords if present before stacking, while also not modifying the input spectra.
I added unit tests to check the behavior (previously failing on main, now passing), and also tested on a tilenight+ztile run to make sure I didn't break the regular pipeline. This isn't strictly needed for Kibo, but I would like to get it in for the Kibo tag for convenience.