Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightqa: kibo fixes #2361

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Nightqa: kibo fixes #2361

merged 3 commits into from
Sep 7, 2024

Conversation

araichoor
Copy link
Contributor

This PR should address:

Outputs of the desi_night_qa runs for those three cases / nights are here: https://data.desi.lbl.gov/desi/users/raichoor/nightqa_dev/nightqa_v28/

For 20201214 and 20210917, the petalnz-{night}.pdf file is empty, as no tiles are kept for the analysis.

I didn t run desi_night_qa for other nights; hopefully the changes are simple enough that they don t require additional testing... though, I m happy to do so, if you d like me to.

ps: @akremin: sorry for all those issues in night_qa!

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anand. No need for an apology. These issues are all on very old data that your code was never designed to run on. I'm glad the fixes to make it robust were straightforward and not too invasive.

I have tested this branch on kibo for nights 20210223, 20210511, and 20210917; which previously failed but now succeed in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants