fix a logical, but likely harmless indexing bug with backup efftime #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segasai
changed the title
|
Thanks. I agree that this is a bug fix. I think it has no impact on Kibo, but just in case let's wait until we've finished the final Kibo catalogs and tags so that this is merged post-Kibo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the backup efftime calculations, I spotted this place where there is a check for len(indices) where indices is a boolean mask (seems to be an IDL'ism).
I think the current code is not what the author meant, but probably still harmless. It's probably still better to fix.