Code

Trace fix improvements#2386

Code

Merged

sbailey merged 19 commits intomaindesihub/desispec:mainfrom trace_fix_improvementsdesihub/desispec:trace_fix_improvementsCopy head branch name to clipboardNov 19, 2024

+219-139

Commits

Commits on Oct 9, 2024

• move reference spectra transforms into dedicated function.

  Show description for 31710ad
  segasai

  committed
  31710ad

  Copy full SHA for 31710ad

• additional updates

  segasai

  committed
  b35478e

  Copy full SHA for b35478e

• move code into separate function to be reused

  segasai

  committed
  61c241d

  Copy full SHA for 61c241d

• log the internal offsets

  segasai

  committed
  5a1b754

  Copy full SHA for 5a1b754

• subtract continuum when doing internal calirbation

  segasai

  committed
  7f500c5

  Copy full SHA for 7f500c5

• make the continuum subtraction in self-calibration optional

  segasai

  committed
  d5c29cf

  Copy full SHA for d5c29cf

• use actual variance not variance times flux

  segasai

  committed
  389f1e1

  Copy full SHA for 389f1e1

• update window of medianing

  segasai

  committed
  9587395

  Copy full SHA for 9587395

• deal with the fact that different functions oversample differently

  Show description for 764d413
  segasai

  committed
  764d413

  Copy full SHA for 764d413

• make sure arcs are still processed with continuum as before

  segasai

  committed
  ee20370

  Copy full SHA for ee20370

Commits on Oct 10, 2024

• fix variable name

  segasai

  committed
  be4d316

  Copy full SHA for be4d316

Commits on Oct 15, 2024

• switch to f-formatting in a couple of instances

  segasai

  committed
  a4050eb

  Copy full SHA for a4050eb

Commits on Oct 26, 2024

• use correct weights for central wavelength

  segasai

  committed
  2f6e80a

  Copy full SHA for 2f6e80a

Commits on Nov 2, 2024

• update variable names

  Show description for 0f03f5c
  segasai

  committed
  0f03f5c

  Copy full SHA for 0f03f5c

Commits on Nov 4, 2024

• add functions docstrings

  segasai

  committed
  aa1cf83

  Copy full SHA for aa1cf83

Commits on Nov 5, 2024

• get rid of comment on oversampling

  Show description for b3c5ba3
  segasai

  committed
  b3c5ba3

  Copy full SHA for b3c5ba3

• few more typos

  segasai

  committed
  b08cb4e

  Copy full SHA for b08cb4e

Commits on Nov 9, 2024

• make the selection more readable

  segasai

  committed
  ece6b59

  Copy full SHA for ece6b59

• Merge branch 'trace_fix_improvements' of github.com:desihub/desispec into trace_fix_improvements

  segasai

  committed
  083ca2b

  Copy full SHA for 083ca2b