Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save the trace shift offsets in the psf file #2411

Open
wants to merge 1 commit into
base: trace_fix_improvements
Choose a base branch
from

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Nov 11, 2024

This is the proposed followup from #2386 (assuming it's merged)
I propose to save the trace-shift offsets (in wavelength) in the psf file, to allow monitoring/improvement/debugging.
The extension/column names are somewhat temporary/can be changed if needed.
The increase in the file size from this is tiny ~ 5% for ~ 1Mb sized psf files.

One could in principle make this optional, i.e. save the offsets if some command-line argument is passed.

@coveralls
Copy link

Coverage Status

coverage: 30.072% (-0.01%) from 30.086%
when pulling 9867229 on write_trace
into 083ca2b on trace_fix_improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants