Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacewatch downloads and other updates #58

Merged
merged 33 commits into from
Nov 30, 2023
Merged

Spacewatch downloads and other updates #58

merged 33 commits into from
Nov 30, 2023

Conversation

weaverba137
Copy link
Member

This PR

A few more operational tests are needed before merging, but go ahead and review if you get a chance.

@weaverba137 weaverba137 self-assigned this Nov 1, 2023
@coveralls
Copy link

coveralls commented Nov 1, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling 7284267 on spacewatch-etc
into a1dff98 on main.

@weaverba137
Copy link
Member Author

@sbailey, this is ready for review and merge. There's nothing particularly controversial here, so if you don't have time that's fine. All aspects have been operationally tested.

@araichoor, Spacewatch downloads are possible again, and I've filled in the backlog at NERSC. However, this is using http instead of https. If we move back to https, that will be a separate issue/PR.

@araichoor
Copy link

thanks a lot @weaverba137!
I ve zero idea of pros/cons of using http vs. https; if the current scheme works to download the images, then perfect, no?

@weaverba137
Copy link
Member Author

One more check before merging. I hope to merge this tomorrow, 30 November.

@weaverba137 weaverba137 merged commit 917143c into main Nov 30, 2023
16 checks passed
@weaverba137 weaverba137 deleted the spacewatch-etc branch November 30, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants