-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.3.1 release candidate #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d do not constrain sigma and vshift to be within +/-20 percent on final fitting iteration
Pull Request Test Coverage Report for Build 5859917529Details
💛 - Coveralls |
…k-10153-39633315489120894 get stuck
…but fit He II 1640 independently of the other Balmer+He lines
… vdisp grid to 50 km/s
…ll routines to simplify the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a variety of fixes and updates and is a
2.3.1
release candidate.Highlights include:
2.3.0
tests when one or more cameras on the first spectrum in a given healpixel is fully masked.2.3.0
.xtol
convergence criterion parameter inscipy.optimize.least_squares
from 1e-2 to its default (1e-8) to prevent the optimization from stopping before actual convergence. One example where this matters issv3-bright-25918-39627758090851408
. I also removed the requirement that the final velocity widths and centers cannot change by more than +/-20% during the final round of fitting. I found that objects likesv3-bright-25918-39627758090851408
require the additional flexibility after some of the constraints are relaxed in the final iteration. I will need to do some additional larger-scale tests to ensure this change doesn't introduce other problems, however._FLUX
and_FLUX_IVAR
parameters are now derived using the method documented inEquivalent width uncertainties are significantly lower in v2 #127 (comment). See the full thread in Equivalent width uncertainties are significantly lower in v2 #127 for additional details and caveats regarding these parameters.