Finalize daily patching #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
approved these changes
Oct 7, 2024
|
I'm ok with the coverage decreasing due to adding "untested" patching code. Although it hasn't been tested with unit tests, it is a one-off usage that has been extensively checked my multiple people on the real daily files where it matters. |
|
@sbailey, yes, at some point I will increase the test coverage for the entire package, but that requires special techniques: a mock database or something conceptually similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures the code changes needed to finalize patching of missing data described in desihub/desispec#2345. Since the changes in the files are already accepted or close to acceptance, this should be a non-controversial PR. A corresponding tag will be created after merging.