Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for defining content id in email attachments #16

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

leonlipe
Copy link

Added an option for defining content ids in email attachments, this allow to send an inline image in the message.

I use this plugin for an app, and I though it could be helpful for others.

@antony
Copy link
Collaborator

antony commented Jul 5, 2017

Hi @leonlipe

Thanks for this - I agree this could be very useful for others.

Would you be able to add a test to ensure that this doesn't regress in future? I'm eager to keep the test coverage on this plugin at a high level, again to benefit others.

I'll fix the travis build in the meantime - not sure why it's failing like that.

Cheers,
Antony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants