Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with clang #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation with clang #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions base/platform/linux/base_system_media_controls_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ SystemMediaControls::Private::Private()
player().set_loop_status("None");
player().set_rate(1.0);
const auto executeCommand = [=](
GObject::Object,
gi::repository::GObject::Object,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gi::repository::GObject::Object,
auto

Gio::DBusMethodInvocation invocation) {
base::Integration::Instance().enterFromEventLoop([&] {
_commandRequests.fire_copy(
Expand Down Expand Up @@ -232,23 +232,23 @@ SystemMediaControls::Private::Private()
return true;
});
player().property_loop_status().signal_notify().connect([=](
GObject::Object,
GObject::ParamSpec) {
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
Comment on lines +235 to +236
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
auto,
auto) {

base::Integration::Instance().enterFromEventLoop([&] {
_commandRequests.fire_copy(
LoopStatusToCommand(player().get_loop_status()));
});
});
player().property_shuffle().signal_notify().connect([=](
GObject::Object,
GObject::ParamSpec) {
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
Comment on lines +243 to +244
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
auto,
auto) {

base::Integration::Instance().enterFromEventLoop([&] {
_commandRequests.fire_copy(Command::Shuffle);
});
});
player().property_volume().signal_notify().connect([=](
GObject::Object,
GObject::ParamSpec) {
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
Comment on lines +250 to +251
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gi::repository::GObject::Object,
gi::repository::GObject::ParamSpec) {
auto,
auto) {

base::Integration::Instance().enterFromEventLoop([&] {
_volumeChangeRequests.fire_copy(player().get_volume());
});
Expand Down