Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Post Button to Left Bar #110

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

metaspartan
Copy link
Contributor

@metaspartan metaspartan commented Jun 9, 2021

Adds a "Create Post" button to the left bar navigation. Basically extremely useful to be able to post easily.

Preview:
image

@metaspartan metaspartan requested a review from a team as a code owner June 9, 2021 06:22
@metaspartan
Copy link
Contributor Author

@maebeam @lazynina would be good to get opinions on this, kind of a must have for any desktop user?

@lazynina
Copy link
Member

this doesn't stylistically match the left sidebar and I don't know that this is a necessity. Desktop users can create posts from the bitclout.com/browse and redirecting them to a different page doesn't seem to be the most effective solution.

If we were to add some ability to create a post from anywhere in the app, I would prefer that we open a modal so we don't take users out of their current place in the application. Additionally, I'd like to see this option in desktop only as we already have the + sign to create a post on mobile (or we remove that option from mobile).

@maebeam thoughts?

@metaspartan
Copy link
Contributor Author

this doesn't stylistically match the left sidebar and I don't know that this is a necessity. Desktop users can create posts from the bitclout.com/browse and redirecting them to a different page doesn't seem to be the most effective solution.

If we were to add some ability to create a post from anywhere in the app, I would prefer that we open a modal so we don't take users out of their current place in the application. Additionally, I'd like to see this option in desktop only as we already have the + sign to create a post on mobile (or we remove that option from mobile).

@maebeam thoughts?

+1 to the modal idea for creating new posts outside of /browse, it is just a pain on desktop to have to click home each time which is small text in navigation. Easier certainly to hit a big button and less confusing to new users. We could make the color fit more into the theme that it is selected too rather than a bright blue and have it popup a modal.

@lazynina
Copy link
Member

this doesn't stylistically match the left sidebar and I don't know that this is a necessity. Desktop users can create posts from the bitclout.com/browse and redirecting them to a different page doesn't seem to be the most effective solution.
If we were to add some ability to create a post from anywhere in the app, I would prefer that we open a modal so we don't take users out of their current place in the application. Additionally, I'd like to see this option in desktop only as we already have the + sign to create a post on mobile (or we remove that option from mobile).
@maebeam thoughts?

+1 to the modal idea for creating new posts outside of /browse, it is just a pain on desktop to have to click home each time which is small text in navigation. Easier certainly to hit a big button and less confusing to new users. We could make the color fit more into the theme that it is selected too rather than a bright blue and have it popup a modal.

I think having the color match the theme and having the button resized (it's bit large IMO) would help with this issue. I would still push for modal instead of directing to the "create post" page, which is a bit bare and unfriendly.

@iPaulPro
Copy link
Contributor

It's a feature that people really like in BitClout+. Using the modal is actually not ideal because it's very easy to accidentally dismiss it and lose your draft.

People are constructing posts with a thousand or more characters and having a dedicated draft page is quite valuable.

It should certainly be a secondary button, as far as style.

@metaspartan
Copy link
Contributor Author

It's a feature that people really like in BitClout+. Using the modal is actually not ideal because it's very easy to accidentally dismiss it and lose your draft.

People are constructing posts with a thousand or more characters and having a dedicated draft page is quite valuable.

It should certainly be a secondary button, as far as style.

Fixed up the styling good to go there, Yes I agree with you on that @iPaulPro to think about that more, accidentally dismissing the modal window would be such a pain if deep in a draft... So +1 to keeping it as separate page like it is

@metaspartan
Copy link
Contributor Author

@lazynina @maebeam thoughts? Button now matches theme and is a bit more integrated looking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants