Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: orval with ajv specified at 8 [TESTENG-121] #10189

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Nov 1, 2024

Ticket

TESTENG-121

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2024
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2be8594
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67253d3463790700084e9951
😎 Deploy Preview https://deploy-preview-10189--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.26%. Comparing base (9a30f26) to head (2be8594).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10189      +/-   ##
==========================================
- Coverage   54.28%   54.26%   -0.03%     
==========================================
  Files        1259     1259              
  Lines      157285   157285              
  Branches     3643     3643              
==========================================
- Hits        85384    85346      -38     
- Misses      71768    71806      +38     
  Partials      133      133              
Flag Coverage Δ
backend 45.89% <ø> (-0.07%) ⬇️
harness 71.15% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@JComins000 JComins000 force-pushed the jcom/TESTENG-121/orval-in-test-what-if-just-ajv-8 branch from a2ce8a4 to 2be8594 Compare November 1, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant