ci: reduce allowed migration time to 15 minutes and stop uploading #10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
mackrorysd
changed the title
jgongd
reviewed
Dec 3, 2024
| # If a migration takes longer than that we have hit an issue a customer will likely hit too. | ||
| time_start = time.time() | ||
| time_last_report = time_start | ||
| while time_start - time.time() < 2 * 60 * 60: | ||
| while time_start - time.time() < 15 * 60: |
There was a problem hiding this comment.
This line may also be relevant:
determined/.circleci/real_config.yml
Line 2149 in 40a70cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: reduce allow migration time to 15 minutes and stop uploading
Description
We're just using CircleCI instead of the database now. Reducing the time to have lower tolerance for slow migrations, and just logging the time it takes for master to come up instead of uploading results.
Test Plan
test-perf should be green after this.