Fix clippy warnings (#475)

src/bin/pica/util.rs

@@ -21,7 +21,7 @@ impl fmt::Display for CliError {
             CliError::Xml(ref e) => e.fmt(f),
             CliError::Io(ref e) => e.fmt(f),
             CliError::Pica(ref e) => e.fmt(f),
-            CliError::Other(ref s) => f.write_str(&**s),
+            CliError::Other(ref s) => f.write_str(s),
         }
     }
 }

src/common.rs

@@ -42,7 +42,7 @@ fn parse_escaped_char(i: &[u8]) -> ParseResult<char> {
 
 /// Parse a non-empty block of text that doesn't include \ or ".
 
-fn parse_literal<'a>(i: &'a [u8]) -> ParseResult<&'a str> {
+fn parse_literal(i: &[u8]) -> ParseResult<&str> {
     map_res(
         verify(is_not("\'\\"), |s: &[u8]| !s.is_empty()),
         std::str::from_utf8,
@@ -57,7 +57,7 @@ enum StringFragment<'a> {
 }
 
 /// Combine parse_literal, parse_escaped_char into a StringFragment.
-fn parse_fragment<'a>(i: &'a [u8]) -> ParseResult<StringFragment<'a>> {
+fn parse_fragment(i: &[u8]) -> ParseResult<StringFragment> {
     alt((
         map(parse_literal, StringFragment::Literal),
         map(parse_escaped_char, StringFragment::EscapedChar),

src/field.rs

@@ -27,7 +27,7 @@ const RS: char = '\x1E';
 const SP: char = '\x20';
 
 /// A PICA+ field, that may contian invalid UTF-8 data.
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct Field {
     pub(crate) tag: Tag,
     pub(crate) occurrence: Option<Occurrence>,

src/matcher/common.rs

@@ -7,7 +7,7 @@ use nom::combinator::value;
 use crate::common::ParseResult;
 
 /// Boolean Operators.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum BooleanOp {
     And, // and, "&&"
     Or,  // or, "||"
@@ -23,7 +23,7 @@ impl fmt::Display for BooleanOp {
 }
 
 /// Comparison Operators
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum ComparisonOp {
     Eq,         // equal, "=="
     Ne,         // not equal, "!="

src/matcher/occurrence_matcher.rs

@@ -11,7 +11,7 @@ use crate::common::ParseResult;
 use crate::occurrence::{parse_occurrence_digits, Occurrence};
 use crate::Error;
 
-#[derive(Debug, PartialEq, Clone)]
+#[derive(Debug, PartialEq, Eq, Clone)]
 pub enum OccurrenceMatcher {
     Some(Occurrence),
     Range(Occurrence, Occurrence),

src/matcher/subfield_matcher.rs

@@ -30,7 +30,7 @@ macro_rules! maybe_lowercase {
 }
 
 /// A subfield matcher.
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum SubfieldMatcher {
     Comparison(Vec<char>, ComparisonOp, BString),
     Exists(Vec<char>),

src/matcher/tag_matcher.rs

@@ -13,7 +13,7 @@ use crate::common::ParseResult;
 use crate::tag::{parse_tag, Tag};
 use crate::Error;
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum TagMatcher {
     Some(Tag),
     Pattern(Vec<char>, Vec<char>, Vec<char>, Vec<char>),

src/occurrence.rs

@@ -16,7 +16,7 @@ use crate::common::ParseResult;
 use crate::error::Error;
 
 /// A PICA+ occurrence.
-#[derive(Debug, Clone, PartialEq, PartialOrd)]
+#[derive(Debug, Clone, PartialEq, Eq, PartialOrd)]
 pub struct Occurrence(BString);
 
 /// Parses digits of a PICA+ occurrence.

src/parser.rs

@@ -15,7 +15,7 @@ use crate::Path;
 const NL: char = '\x0A';
 
 /// An error that can occur when parsing PICA+ records.
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct ParsePicaError {
     pub message: String,
     pub data: Vec<u8>,

src/path.rs

@@ -19,7 +19,7 @@ use crate::{Error, Result, Tag};
 
 use std::str::FromStr;
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct Path {
     pub(crate) tag: TagMatcher,
     pub(crate) occurrence: OccurrenceMatcher,

src/record.rs

@@ -13,7 +13,7 @@ use std::ops::Deref;
 use std::result::Result as StdResult;
 
 /// A PICA+ record, that may contian invalid UTF-8 data.
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct ByteRecord {
     pub(crate) raw_data: Option<Vec<u8>>,
     pub(crate) fields: Vec<Field>,
@@ -405,7 +405,7 @@ impl Deref for ByteRecord {
 }
 
 /// A PICA+ record, that guarantees valid UTF-8 data.
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct StringRecord(ByteRecord);
 
 impl Deref for StringRecord {

src/subfield.rs

@@ -16,7 +16,7 @@ use crate::common::ParseResult;
 use crate::error::{Error, Result};
 
 /// A PICA+ subfield, that may contian invalid UTF-8 data.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Subfield {
     pub(crate) code: char,
     pub(crate) value: BString,

src/tag.rs

@@ -20,7 +20,7 @@ use crate::error::Error;
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Tag(pub(crate) BString);
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum Level {
     Main,
     Local,
@@ -86,9 +86,9 @@ impl Tag {
     ///     assert_eq!(Tag::new("003@")?.level(), Level::Main);
     ///     Ok(())
     /// }
-    /// ```    
+    /// ```
     pub fn level(&self) -> Level {
-        match self.0.get(0) {
+        match self.0.first() {
             Some(b'0') => Level::Main,
             Some(b'1') => Level::Local,
             Some(b'2') => Level::Copy,