Fix clippy warnings (#799)

Signed-off-by: Nico Wagner <[email protected]>

crates/pica-toolkit/src/commands/convert/binary.rs

@@ -33,15 +33,15 @@ impl ByteRecordWrite for BinaryWriter {
                 occurrence.write_to(&mut self.writer)?;
             }
 
-            self.writer.write_all(&[b' '])?;
+            self.writer.write_all(b" ")?;
             for subfield in field.subfields() {
                 subfield.write_to(&mut self.writer)?;
             }
 
-            self.writer.write_all(&[b'\x1e'])?;
+            self.writer.write_all(b"\x1e")?;
         }
 
-        self.writer.write_all(&[b'\x1d'])?;
+        self.writer.write_all(b"\x1d")?;
         Ok(())
     }
 

crates/pica-toolkit/src/commands/convert/import.rs

@@ -27,22 +27,22 @@ impl ByteRecordWrite for ImportWriter {
         &mut self,
         record: &ByteRecord,
     ) -> std::io::Result<()> {
-        self.writer.write_all(&[b'\x1d', b'\x0a'])?;
+        self.writer.write_all(b"'\x1d\x0a")?;
 
         for field in record.iter() {
-            self.writer.write_all(&[b'\x1e'])?;
+            self.writer.write_all(b"\x1e")?;
 
             self.writer.write_all(field.tag())?;
             if let Some(occurrence) = field.occurrence() {
                 occurrence.write_to(&mut self.writer)?;
             }
 
-            self.writer.write_all(&[b' '])?;
+            self.writer.write_all(b" ")?;
             for subfield in field.subfields() {
                 subfield.write_to(&mut self.writer)?;
             }
 
-            self.writer.write_all(&[b'\x0a'])?;
+            self.writer.write_all(b"\x0a")?;
         }
 
         Ok(())

crates/pica-toolkit/src/commands/convert/json.rs

@@ -20,7 +20,7 @@ impl JsonWriter {
                 BufWriter::new(Box::new(stdout()))
             };
 
-        writer.write_all(&[b'['])?;
+        writer.write_all(b"[")?;
         Ok(Self { writer, count: 0 })
     }
 }
@@ -71,7 +71,7 @@ impl ByteRecordWrite for JsonWriter {
     }
 
     fn finish(&mut self) -> io::Result<()> {
-        self.writer.write_all(&[b']'])?;
+        self.writer.write_all(b"]")?;
         self.writer.flush()
     }
 }

crates/pica-toolkit/src/commands/convert/plain.rs

@@ -34,7 +34,7 @@ impl ByteRecordWrite for PlainWriter {
                 occurrence.write_to(&mut self.writer)?;
             }
 
-            self.writer.write_all(&[b' '])?;
+            self.writer.write_all(b" ")?;
 
             for subfield in field.subfields() {
                 self.writer
@@ -44,7 +44,7 @@ impl ByteRecordWrite for PlainWriter {
                 )?;
             }
 
-            self.writer.write_all(&[b'\n'])?;
+            self.writer.write_all(b"\n")?;
         }
 
         Ok(())

crates/pica-toolkit/src/commands/hash.rs

@@ -50,12 +50,6 @@ pub(crate) struct Hash {
     filenames: Vec<OsString>,
 }
 
-#[derive(Debug, Deserialize, Serialize)]
-struct Row {
-    idn: Option<String>,
-    hash: String,
-}
-
 impl Hash {
     pub(crate) fn run(self, config: &Config) -> CliResult<()> {
         let mut progress = Progress::new(self.progress);