Accept strings and lists for ssh_allow_users #850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes our ssh_hardening role accept both strings and lists for
ssh_allow_users
.@rndmh3ro WDYT?
Initially I thought this may be a good idea to allow more flexible use. But there is also an overlap with our documentation that states this should be a string since a long time. Also if we allow two types to be passed here we cannot use argument spec to check the variable anymore.
The alternative would be to add a type check to argument spec and simply fail before executing.
closes #838