Convert uname variable to global variable #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `uname -m` is executed multiple times, and it would be nicer to move it to a global variable for reuse. At the same time, we should rename the variable to a better name. Signed-off-by: Ivo van Doorn <[email protected]>
IvDoorn
force-pushed
the
Move-uname-to-global-variable
branch
from
a877fe2
to
bb91c0a
Compare
|
nice simplification, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
uname -mis executed multiple times, and it would be nicer to move it to a global variable for reuse. At the same time, we should rename the variable to a better name.