fix(instance): send error instead of panick

Signed-off-by: Mauran <[email protected]>

controller/src/errors.rs

@@ -20,6 +20,9 @@ pub enum ApiError {
 
     #[error("Scheduling error")]
     SchedulingError(#[from] tonic::Status),
+
+    #[error("Instance not created")]
+    InstanceNotCreated{message: String},
 }
 
 impl IntoResponse for ApiError {
@@ -32,6 +35,7 @@ impl IntoResponse for ApiError {
             ApiError::SerializationError(e) => (StatusCode::BAD_REQUEST, e.to_string()),
             ApiError::DatabaseError(e) => (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()),
             ApiError::SchedulingError(e) => (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()),
+            ApiError::InstanceNotCreated{message} => (StatusCode::BAD_REQUEST, message.to_string()),
         };
 
         let payload = json!({

controller/src/routes/instances.rs

@@ -5,7 +5,7 @@ use crate::types::instance_request::InstanceRequest;
 use crate::types::instance_status::InstanceStatus;
 use axum::extract::Path;
 use axum::Json;
-use log::{error, trace};
+use log::{trace, warn, error};
 use orka_proto::scheduler_controller::{SchedulingRequest, Workload, WorkloadInstance};
 use serde_json::{self, json, Value};
 use validator::Validate;
@@ -94,8 +94,13 @@ pub async fn post_instance(body: String) -> anyhow::Result<Json<Value>, ApiError
 
             let mut stream = client.schedule_workload(request).await?;
 
+            stream.message().await.map_err(|e|{
+                warn!("Error while creating the instance: {:?}", e);
+                ApiError::InstanceNotCreated{message: format!("Instance not created {:?}", e)}
+            })?;
+
             tokio::spawn(async move {
-                while let Some(status) = stream.message().await.unwrap() {
+                while let Ok(Some(status)) = stream.message().await {
                     trace!("STATUS={:?}", status);
                     let result = DB_BATCH.lock().unwrap().batch.set(
                         &status.instance_id,