Event modification #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan Guilbault <[email protected]>
That's a copy of ImportCitiesJob Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Now it use only .json files : so a README.md and a *.example can be added without bug Signed-off-by: Ronan Guilbault <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan Guilbault <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
-DONLY_CHECK_EVENTS=true Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Test with Nantes Machine Learning Meetup Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
Signed-off-by: Ronan GUILBAULT <[email protected]>
- CREATE_INDEX : useful if an ES service is running (create index then import data) - REMAPPING_EVENTS : useful when reload Events (delete then re-create 'events' mapping) Signed-off-by: Ronan GUILBAULT <[email protected]>
Option '-D' : CHECK_EVENTS Signed-off-by: Ronan GUILBAULT <[email protected]>
|
Je l'ai mis dans cette branche car c'est indirectement lié :
Je vais faire en sorte que |
Signed-off-by: Ronan GUILBAULT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les Events sont maintenant ordonnés comme ceci :
J'ai aussi ajouté un README qui sera affiché sur le dépôt dans le dossier
src/main/resources/events, comme ceci. J'ai essayé d'être le plus clair possible, avec la procédure ou la mini-référence. J'ai également mis un JSON exemple. Est-ce que ça convient ?Enfin, il y a une fonction pour vérifier que les champs obligatoires d'un Event sont présents. Pour le moment, il y a :
id(avec correspondance du nom de fichier)name(quand même)type(obligé, ça perturbe l'affichage pour la ville)description(celui-là je sais pas si on le met obligatoire ou pas, mais au niveau du rendu de la page, je pense qu'il faut mieux le mettre. Sinon on met par défaut "Pas de description.").Bon après j'ai mis 2 champs en recommandé dans le README :
avataretwebsite.Ah oui dernière chose : j'avais pensé à créer un label spécifique lorsqu'un PR sert pour modifier un Event. J'ai mis
event modificationdans le README, mais est-ce une bonne idée ?