[terraform] Add Custom Download Server Support for Terraform Dev Container Feature #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire full URL with protocol
iTiPo
force-pushed
the
custom-server-to-download-terraform
branch
from
4f13686 to
7f654ca
Compare
|
@microsoft-github-policy-service agree |
Kaniska244
approved these changes
May 21, 2025
|
@Kaniska244 can you tell me approximately how long I need to wait for maintainers? Maybe I should write to someone asking them to view this PR? |
AlvaroRausell
requested changes
May 30, 2025
Comment on lines
+73
to
+82
| }, | ||
| "custom_download_server": { | ||
| "image": "mcr.microsoft.com/devcontainers/base:jammy", | ||
| "features": { | ||
| "terraform": { | ||
| "version": "1.6.5", | ||
| "customDownloadServer": "https://releases.hashicorp.com" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Since the default is already "https://releases.hashicorp.com", this test makes the case that adding it does not break functionality. However, I would like to test that it does override - I can see from the code that it does, but still would be good to systematically test it. Would you be able to make an additional test with a fake URL and expect that it fails please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to specify a custom download server for the Terraform Dev Container feature. This enhancement is particularly useful for organizations that maintain internal mirrors or have proxies for HashiCorp downloads, allowing them to control the source of Terraform and Sentinel packages.
Key Changes:
customDownloadServerin thedevcontainer-feature.jsonto allow users to specify an alternative server URL.install.shscript to utilize the custom server URL when provided, ensuring that the download process respects the user's configuration.NOTES.mdto include guidelines on using the custom download server, along with security considerations to ensure users are aware of potential risks.Motivation:
Testing:
scenarios.jsonto include cases for custom download server usage, ensuring that the feature works as expected with different configurations.