Skip to content

[terraform] Add Custom Download Server Support for Terraform Dev Container Feature #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

iTiPo
Copy link

@iTiPo iTiPo commented May 18, 2025

This pull request introduces the ability to specify a custom download server for the Terraform Dev Container feature. This enhancement is particularly useful for organizations that maintain internal mirrors or have proxies for HashiCorp downloads, allowing them to control the source of Terraform and Sentinel packages.

Key Changes:

  • Added a new option customDownloadServer in the devcontainer-feature.json to allow users to specify an alternative server URL.
  • Updated the install.sh script to utilize the custom server URL when provided, ensuring that the download process respects the user's configuration.
  • Enhanced documentation in NOTES.md to include guidelines on using the custom download server, along with security considerations to ensure users are aware of potential risks.

Motivation:

  • Flexibility: Organizations can now use their own mirrors or proxies, which is essential for environments with restricted internet access or specific compliance requirements.
  • Security: By allowing users to specify a trusted server, the feature helps mitigate risks associated with downloading software from untrusted sources.
  • Compliance: This change supports organizations that need to adhere to internal policies regarding software distribution and updates.

Testing:

  • Updated test scenarios in scenarios.json to include cases for custom download server usage, ensuring that the feature works as expected with different configurations.

@iTiPo iTiPo requested a review from a team as a code owner May 18, 2025 11:20
@iTiPo iTiPo force-pushed the custom-server-to-download-terraform branch from 4f13686 to 7f654ca Compare May 19, 2025 17:10
@iTiPo
Copy link
Author

iTiPo commented May 19, 2025

@microsoft-github-policy-service agree

Copy link
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine & test scenarios validated. To be further reviewed by maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants