Skip to content

[nvidia-cuda] - Ubuntu focal EOL change for nvidia-cuda #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Kaniska244
Copy link
Contributor

Ref: #90 , #261

Description: The ubuntu focal is going out of support from May 31, 2025. So changing the nvidia-cuda repo url to the ubuntu jammy (22.04) version url from the focal one. Also not moving to the ubuntu noble repo as it appears to have only limiteds versions cuda & libcudnn available.

Changlog: The following changes are done.

  • Changed the repo url in install.sh
  • Version bump in devcontainer-feature.json

Checklist:

  • All checks are passed.

@Kaniska244 Kaniska244 marked this pull request as ready for review May 23, 2025 08:43
@Kaniska244 Kaniska244 requested a review from a team as a code owner May 23, 2025 08:43
@Kaniska244 Kaniska244 requested a review from AlvaroRausell June 3, 2025 15:46
@@ -1,6 +1,6 @@
{
"id": "nvidia-cuda",
"version": "1.2.1",
"version": "1.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to bump the major version, since this would break compatibility with Ubuntu 20.04 devcontainers. @eljog Do you agree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AlvaroRausell ,

I have updated it to 1.3.0. Kindly let me know if this is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, major version bump should be 2.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AlvaroRausell ,

I have corrected the same.

@Kaniska244 Kaniska244 requested a review from AlvaroRausell June 6, 2025 07:25
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README please?

@Kaniska244
Copy link
Contributor Author

Can you update the README please?

Hello @AlvaroRausell ,

Thank you for pointing this out. I had missed this earlier & its corrected now.

@Kaniska244 Kaniska244 requested a review from AlvaroRausell June 12, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants