Polish Calendar UI (month view) #424
Conversation
components/app/Calendar.vue
Outdated
| @@ -35,7 +33,7 @@ const onEventClick = (event: any, e: any) => { | |||
| :events-on-month-view="true" | |||
| :twelve-hour="true" | |||
| :events="group.items" | |||
| :start-week-on-sunday="false" | |||
| :start-week-on-sunday="true" | |||
There was a problem hiding this comment.
We might have to rebase this branch because due to another PR that put this in.
There was a problem hiding this comment.
technically it won't overwrite because it's the same line.
nuxt.config.ts
Outdated
| @@ -82,6 +81,8 @@ export default defineNuxtConfig({ | |||
| componentIslands: true, | |||
| }, | |||
|
|
|||
| compatibilityDate: '2024-10-18', | |||
There was a problem hiding this comment.
I'm not sure what this is for, was this needed?
There was a problem hiding this comment.
this is from Nuxt. we don't necessarily need to include it in the PR.
There was a problem hiding this comment.
Sounds good @arashsheyda. I think it's good to merge once this is removed! Let me know what you think.
@johnjovero98 could you remove this line?
There was a problem hiding this comment.
I removed line 84 and got this branch up to date :>
|
Thanks @johnjovero98 this is great I'm merging this. |
|
@allcontributors add @johnjovero98 for code |
|
I've put up a pull request to add @johnjovero98! 🎉 |
dgmouris
added
the
hacktoberfest-accepted
What issue is this referencing?
#394
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checksHave you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use?Here is a demo gif of the calendar redesign.
Note: I used pure CSS to make the changes instead of tailwind classes. I'm not sure if that will cause any performance issues. Please let me know if I need to refactor it :>