Calendar week view UI update #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o98/DES-Website into calendar-week-view-394
…o98/DES-Website into calendar-week-view-394
…o98/DES-Website into calendar-week-view-394
dgmouris
approved these changes
Oct 25, 2024
Comment on lines
+56
to
+65
| const eventItems = groupCalendar.items | ||
| eventItems.forEach((event) => { | ||
| const START_DATE = '12:00:00 AM' | ||
| const END_DATE = '11:59:59 PM' | ||
|
|
||
| // condition where an event is an "allDay" event fix | ||
| if ((event.start.toLocaleTimeString() === START_DATE) && (event.end.toLocaleTimeString() === END_DATE)) { | ||
| event.allDay = true | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is great @johnjovero98 I'm fairly sure this takes into account this fix https://github.com/devedmonton/DES-Website/pull/429/files correct?
This looks pretty awesome to me so far I'm good to merge this.
There was a problem hiding this comment.
Yes, I rebased my branch that includes those changes from PR 429.
|
This looks great just something to note in the future is that in firefox the "all day" event is not showing so maybe @johnjovero98 could file a bug later with https://github.com/antoniandre/vue-cal-v4/issues. I'm going to merge this and we can deal with it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this referencing?
#394
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checksHave you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use?demo: