This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
preprocess groupphoto images #34
Open
clif-os
wants to merge
18
commits into
staged
Choose a base branch
from
cc/use-s3-not-ajax
base: staged
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clif-os
changed the title
preprocess grouphoto jpegs, clean up logs format
preprocess groupphoto images
Sep 6, 2020
@julianduque would you like me to write an endpoint that uses your /deleteObj fn() to remove both the gif and the jpeg by their filename? |
crcastle
force-pushed
the
cc/use-s3-not-ajax
branch
from
October 15, 2020 18:47
28b6062
to
f75bbcc
Compare
crcastle
force-pushed
the
cc/use-s3-not-ajax
branch
from
October 16, 2020 21:41
f75bbcc
to
e392136
Compare
Hey @clif-os - These changes are causing an error for me. I'm getting an error when I click "Share with conference" after recording a GIF. Heroku app log:
|
Hey @crcastle I launched this branch here and am not seeing that issue: Is the bucket you're using a bucket that already exists? (This change cannot be placed onto an existing gif booth bucket as it diverges from the file/folder structure). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3.getObject
instead ofajax
to fetch image buffers