Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add npm run build step for client react app in the README #41

Open
wants to merge 1 commit into
base: staged
Choose a base branch
from

Conversation

vishalol
Copy link
Contributor

For client/build folder to exist, we need to run npm run build in the client react app folder. Otherwise, after running npm start locally, we get the error that client/build/index.html does not exist. Updated the readme to add the additional step.

@vishalol
Copy link
Contributor Author

@crcastle please review :)

@crcastle
Copy link
Contributor

Hi @vishalCR7, I don't get that error. Did you do the following?

cd client
npm install
cd ..
npm install
npm start

When you run npm start from the root folder, that runs npm run client, which runs node start-client.js, which runs npm start from the client directory, which runs react-scripts start.

react-scripts start doesn't require a build folder to be created for local development. For a production deploy, the heroku-postbuild step runs npm run build. Did you try to deploy it to production somewhere else?

@vishalol
Copy link
Contributor Author

I encountered it while I was running it on GitHub codespaces (similar to running it locally). This is the screenshot of the error.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants