Raise TypeError instead of panic on doing fetch_tile from striped TIFFs #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
May 13, 2025
Comment on lines
+72
to
+76
| let tile = ifd | ||
| .fetch_tile(x, y, reader.as_ref()) | ||
| .await | ||
| .map_err(|err| PyTypeError::new_err(err.to_string()))?; | ||
|
|
There was a problem hiding this comment.
Ideally we'd have an error enum with known variants so that we can check specifically for "trying to load a strip tiff as a tiled tiff" and return a Python TypeError for that specific case.
But this is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
.fetch_tile()on a striped TIFF (that does not have tiles).How I did it
.unwrap()with.map_err(|err| PyTypeError::new_err(err.to_string()))TypeErroris raised when calling.fetch_tile()on a striped TIFFHow you can test it
cd python && uv run pytest --verboseor look at CIRelated Issues
Closes #98