fix(ingestor-api): stricter collections endpoints

lib/ingestor-api/runtime/src/collection.py

@@ -14,13 +14,10 @@ def ingest(collection: StacCollection):
     does necessary preprocessing,
     and loads into the PgSTAC collection table
     """
-    try:
-        creds = get_db_credentials(os.environ["DB_SECRET_ARN"])
-        with PgstacDB(dsn=creds.dsn_string, debug=True) as db:
-            loader = Loader(db=db)
-            loader.load_collection(file=collection, insert_mode=Methods.upsert)
-    except Exception as e:
-        print(f"Encountered failure loading collection into pgSTAC: {e}")
+    creds = get_db_credentials(os.environ["DB_SECRET_ARN"])
+    with PgstacDB(dsn=creds.dsn_string, debug=True) as db:
+        loader = Loader(db=db)
+        loader.load_collection(file=collection, insert_mode=Methods.upsert)
 
 
 def delete(collection_id: str):

lib/ingestor-api/runtime/src/main.py

@@ -88,33 +88,24 @@ def cancel_ingestion(
 @app.post(
     "/collections",
     tags=["Collection"],
-    status_code=201,
     dependencies=[Depends(dependencies.get_username)],
+    status_code=201,
 )
-def publish_collection(collection: schemas.StacCollection):
-    # pgstac create collection
-    try:
-        collection_loader.ingest(collection)
-        return {f"Successfully published: {collection.id}"}
-    except Exception as e:
-        raise HTTPException(
-            status_code=400,
-            detail=(f"Unable to publish collection: {e}"),
-        )
+def publish_collection(
+    collection: schemas.StacCollection
+) -> schemas.StacCollection:
+    collection_loader.ingest(collection)
+    return collection
 
 
 @app.delete(
     "/collections/{collection_id}",
     tags=["Collection"],
     dependencies=[Depends(dependencies.get_username)],
+    status_code=204,
 )
 def delete_collection(collection_id: str):
-    try:
-        collection_loader.delete(collection_id=collection_id)
-        return {f"Successfully deleted: {collection_id}"}
-    except Exception as e:
-        print(e)
-        raise HTTPException(status_code=400, detail=(f"{e}"))
+    collection_loader.delete(collection_id=collection_id)
 
 
 @app.get("/auth/me")