Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom domain names for apis #63

Merged
merged 3 commits into from
Aug 21, 2023
Merged

feat: custom domain names for apis #63

merged 3 commits into from
Aug 21, 2023

Conversation

jjfrench
Copy link
Contributor

@jjfrench jjfrench commented Aug 16, 2023 •
edited by emileten
Loading

example implementation: MAAP-Project/maap-eoapi#15

@jjfrench jjfrench changed the title feat: custom domain names feat: custom domain names for apis Aug 16, 2023
emileten
emileten approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@emileten emileten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed two commits to fix two bugs I described in comments. LGTM now.

lib/ingestor-api/index.ts Show resolved Hide resolved
lib/titiler-pgstac-api/runtime/src/handler.py Show resolved Hide resolved
@emileten emileten mentioned this pull request Aug 18, 2023
Merged
@emileten emileten merged commit c9eeb00 into main Aug 21, 2023
4 checks passed
@emileten emileten deleted the feat/custom-domain-names branch August 21, 2023 09:03
github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
daec1e0 
# [5.1.0](v5.0.0...v5.1.0) (2023-08-21)

### Features

* custom domain names for apis ([#63](#63)) ([c9eeb00](c9eeb00)), closes [#61](#61)
@emileten emileten mentioned this pull request Aug 30, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach alukach approved these changes

@vincentsarago vincentsarago vincentsarago approved these changes

@emileten emileten emileten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjfrench @alukach @vincentsarago @emileten