Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom runtimes option for titiler and ingestor #66

Merged
merged 6 commits into from
Sep 5, 2023
Merged

feat: custom runtimes option for titiler and ingestor #66

merged 6 commits into from
Sep 5, 2023
+171 −59

Conversation

emileten
Copy link
Contributor

@emileten emileten commented Sep 1, 2023 •
edited
Loading

Closes https://github.com/developmentseed/eoapi-cdk/issuhttps://github.com/developmentseed/eoapi-cdk/pullses/55. Adds an option for custom python lambda runtime code for :

  • the titiler construct
  • the ingestor construct

For the ingestor, note that I added two options (apiCode and ingestorCode), since we're creating two lambdas :

  • one for the API in itself that puts the ingestion requests in a queue
  • one that gets the queued ingestion requests and bulk-inserts them in the database.

Defaults are what's in the runtime folders here.

@emileten emileten changed the title custom runtimes option for titiler and ingestor feat: custom runtimes option for titiler and ingestor Sep 1, 2023
@emileten emileten changed the title feat: custom runtimes option for titiler and ingestor feat!: custom runtimes option for titiler and ingestor Sep 1, 2023
@emileten emileten changed the title feat!: custom runtimes option for titiler and ingestor feat: custom runtimes option for titiler and ingestor Sep 1, 2023
@emileten emileten linked an issue Sep 1, 2023 that may be closed by this pull request
Make ingestor and stac api runtime code injectable via props.apiCode. #55
Closed
@vincentsarago vincentsarago mentioned this pull request Sep 1, 2023
Closed
@emileten
Copy link
Contributor Author

emileten commented Sep 4, 2023 •
edited
Loading

@vincentsarago we're good, I switched to PythonFunction and just removed the boto3 requirement that we don't need because it's already in the environment provided by AWS.

Things seem to work, anything else ?

@emileten
wrap the python lambda settings that are optional in an interface to …
9f31c31 
…make things clearer and more configurable, add bundling
@emileten
Copy link
Contributor Author

emileten commented Sep 5, 2023

Could you approve if it looks good 🙏

@emileten emileten merged commit 3aaedae into main Sep 5, 2023
3 checks passed
@emileten emileten deleted the feat/custom-runtimes-titiler-ingestor branch September 5, 2023 08:05
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
@semantic-release-bot
chore(release): 5.4.0 [skip ci]
a1081a2 
# [5.4.0](v5.3.0...v5.4.0) (2023-09-05)

### Features

* custom runtimes option for titiler and ingestor ([#66](#66)) ([3aaedae](3aaedae))
@emileten emileten mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

@sharkinsspatial sharkinsspatial Awaiting requested review from sharkinsspatial

@alukach alukach Awaiting requested review from alukach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ingestor and stac api runtime code injectable via props.apiCode.
2 participants
@emileten @vincentsarago