Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to apps, reorg imports #12

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add logging to apps, reorg imports #12

merged 2 commits into from
Aug 12, 2024

Conversation

alukach
Copy link
Member

@alukach alukach commented Aug 9, 2024

What I am changing

This PR adds a helper to enable stdout logging on the Python applications.

Additionally, I've refactored the imports to comply with PEP-0008 conventions:

Imports should be grouped in the following order:

  1. Standard library imports.
  2. Related third party imports.
  3. Local application/library specific imports.

How I did it

Add simple logs.py helper file.

How you can test it

Start up apps in debug mode, note debug logs regarding connection to the database.

@alukach alukach requested a review from vincentsarago August 9, 2024 23:27
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@alukach alukach merged commit 481efa5 into main Aug 12, 2024
1 check passed
@alukach alukach deleted the feature/logging branch August 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants