Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump eoapi chart version #153

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

ciaransweet
Copy link
Contributor

No description provided.

@ciaransweet
Copy link
Contributor Author

@ranchodeluxe I think I'm missing something but what is the point of 2 version values where one is tied to the other? Wouldn't it just make sense to keep version and drop appVersion? Given I have to update version if I change appVersion

@ciaransweet ciaransweet requested a review from ividito September 25, 2024 12:35
@ividito ividito merged commit 44a7d1b into main Sep 25, 2024
3 checks passed
@ranchodeluxe
Copy link
Contributor

@ranchodeluxe I think I'm missing something but what is the point of 2 version values where one is tied to the other? Wouldn't it just make sense to keep version and drop appVersion? Given I have to update version if I change appVersion

I agree that appVersion seems useless but I've seen somewhere in the helm docs some kind of justification for it and at this point I don't know a chart that doesn't provide both so it's just "convention"

@j08lue j08lue deleted the allowed-extensions-version-bump branch October 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants