Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm template error if docServer settings is not defined #178

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

totycro
Copy link
Contributor

@totycro totycro commented Jan 27, 2025

Sorry, my latest PR actually contains a bug: #176

Now that the values for affinity aren't always present, docServer.settings can be null which leads docServer.settings.affinity to crash.

This PR adds an additional check for this.

@ividito ividito self-requested a review January 27, 2025 15:58
@ividito ividito merged commit 656dc20 into developmentseed:main Jan 27, 2025
3 checks passed
@totycro totycro deleted the empty-affinity-fix branch January 27, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants