Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Google Cloud Storage URLs (like WeatherBench2 data) #51

Closed
wants to merge 8 commits into from

Conversation

yoninachmany
Copy link

What I am changing

How I did it

How you can test it

Screenshot 2024-03-21 at 10 54 52 AM

Related Issues

@vincentsarago vincentsarago mentioned this pull request Mar 21, 2024
@vincentsarago
Copy link
Member

👋 @yoninachmany

Thanks for you PR, I'm a bit worry about adding another dependency. Could we make gcsfs an optional dependency?

@yoninachmany
Copy link
Author

Yes!

P.S. I realized I can use the public HTTPS URL, which is already supported: https://storage.googleapis.com/weatherbench2/datasets/era5/1959-2023_01_10-wb13-6h-1440x721_with_derived_variables.zarr/

@thijsvanwinden
Copy link

@vincentsarago I kind of need this for a project. Anything I can do to get this merged?

@vincentsarago
Copy link
Member

@thijsvanwinden the branch is outated so we would need to update it and also make sure the test/lint passes

I also feel we should have tests added

Sadly I do not have bandwidth to take care of this right now

@abarciauskas-bgse
Copy link
Contributor

@yoninachmany thank you for making these changes - we have decided this repo is going to be a dedicated repo for the VEDA titiler-xarray API, which doesn't require google storage access at this time. And as an FYI, the xarray module has been pulled into the core titiler-repo: https://github.com/developmentseed/titiler/tree/main/src/titiler/xarray/titiler/xarray. If you are still using titiler's xarray technology it would be cool to see a new API repo using GCS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants