-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet from 6.0 to 8.0 #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popalex thanks for the contribution, could you please sign off the commit - https://github.com/devfile/developer-images/pull/171/checks?check_run_id=24622985445
@svor are we good to bump the .net version?
done. |
@ibuziuk changes are good to me. Only the problem with image build: https://github.com/devfile/developer-images/actions/runs/8966779944/job/24670229942?pr=171, but I don't think it's related to the current changes |
@musienko-maxim could you please take a look at why the PR check is failing ? |
the build fails because of eclipse-che/che#22957 |
@popalex could you please rebase your PR to pick up the latest changes from main branch, they contain the fix of image build problem |
Signed-off-by: Alex Popescu <[email protected]>
Done I think. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: popalex, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update dotnet version from 6.0 to 8.0, latest LTS version at this time.
Signed-off-by: Alex Popescu [email protected]