Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet from 6.0 to 8.0 #171

Merged
merged 1 commit into from
May 20, 2024
Merged

Update dotnet from 6.0 to 8.0 #171

merged 1 commit into from
May 20, 2024

Conversation

popalex
Copy link
Contributor

@popalex popalex commented May 6, 2024

Update dotnet version from 6.0 to 8.0, latest LTS version at this time.

Signed-off-by: Alex Popescu [email protected]

Copy link
Contributor

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popalex thanks for the contribution, could you please sign off the commit - https://github.com/devfile/developer-images/pull/171/checks?check_run_id=24622985445
@svor are we good to bump the .net version?

@popalex
Copy link
Contributor Author

popalex commented May 7, 2024

@popalex thanks for the contribution, could you please sign off the commit - https://github.com/devfile/developer-images/pull/171/checks?check_run_id=24622985445

done.

@svor
Copy link
Collaborator

svor commented May 7, 2024

@popalex thanks for the contribution, could you please sign off the commit - https://github.com/devfile/developer-images/pull/171/checks?check_run_id=24622985445 @svor are we good to bump the .net version?

@ibuziuk changes are good to me. Only the problem with image build: https://github.com/devfile/developer-images/actions/runs/8966779944/job/24670229942?pr=171, but I don't think it's related to the current changes

@ibuziuk
Copy link
Contributor

ibuziuk commented May 8, 2024

@musienko-maxim could you please take a look at why the PR check is failing ?

@svor
Copy link
Collaborator

svor commented May 8, 2024

the build fails because of eclipse-che/che#22957

@svor
Copy link
Collaborator

svor commented May 14, 2024

@popalex could you please rebase your PR to pick up the latest changes from main branch, they contain the fix of image build problem

Signed-off-by: Alex Popescu <[email protected]>
@popalex
Copy link
Contributor Author

popalex commented May 19, 2024

Done I think.

Copy link

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: popalex, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 88d1b4c into devfile:main May 20, 2024
2 checks passed
@popalex popalex deleted the dotnet-8 branch May 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants