Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Index Schema Field Filtering #202

Merged
merged 56 commits into from
Apr 8, 2024
Merged

Feature: Index Schema Field Filtering #202

Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
69a9d3c
new parameters and schemas added for field based filtering
michael-valdron Jan 30, 2024
b0ecec3
new types and endpoint signatures to support additional filter parame…
michael-valdron Jan 30, 2024
a1bd7d6
setmap collection type and test cases defined
michael-valdron Feb 6, 2024
2426c82
multi field filtering changes
michael-valdron Feb 6, 2024
a4174fb
setmap changes dynamic typing and union
michael-valdron Feb 23, 2024
cd70b27
AndFilter and FilterResult
michael-valdron Mar 4, 2024
7f062e7
filters use lazy evaluation
michael-valdron Mar 5, 2024
a8dcf1d
StructToMap function
michael-valdron Mar 5, 2024
a292c63
replace setmap (using built-in map) with hashicorp hashset data struc…
michael-valdron Mar 5, 2024
643245d
revert schema changes
michael-valdron Mar 12, 2024
df4720f
use fields instead of reverted getter functions
michael-valdron Mar 12, 2024
a85cdf7
array fuzzy filter & filter options
michael-valdron Mar 13, 2024
f72e496
attribute names field test cases
michael-valdron Mar 13, 2024
fa9de3c
simplify type signatures under filter.go
michael-valdron Mar 13, 2024
46e9678
filter resources test cases
michael-valdron Mar 14, 2024
1e76886
fix filterDevfileArrayFuzzy to consider version schema results before…
michael-valdron Mar 14, 2024
4bb8bdd
filter by starter projects test cases
michael-valdron Mar 14, 2024
ad82342
filter by link names test cases
michael-valdron Mar 14, 2024
54092ef
fix link getters to return the link label rather than the link itself
michael-valdron Mar 14, 2024
388ed8a
filter by command groups test cases
michael-valdron Mar 14, 2024
e0b3976
filter by git remote names test cases
michael-valdron Mar 14, 2024
ef252bb
add missing string field filter test case definitions
michael-valdron Mar 14, 2024
3c8be51
Parameter label sets and getters
michael-valdron Mar 16, 2024
8668184
filter index parameters
michael-valdron Mar 16, 2024
b0f665d
fix icon parameter conflict
michael-valdron Mar 19, 2024
93dea0a
revert error returns for FilterDevfileSchemaVersion
michael-valdron Mar 19, 2024
ec29765
add iconUri field to IndexParams
michael-valdron Mar 20, 2024
9a66e97
add filter result name field and return error if eval fails
michael-valdron Mar 20, 2024
524d353
only perform field filtering with IndexParams tied to a field
michael-valdron Mar 20, 2024
46a728d
fix version regex in openapi spec
michael-valdron Mar 20, 2024
50f27f2
'/v2index/all?arch=arm64&language=java' call integration test case
michael-valdron Mar 21, 2024
7c93387
REST doc update
michael-valdron Mar 21, 2024
8811faf
update generated source from doc changes
michael-valdron Mar 25, 2024
c4c97c6
remove minSchemaVersion and maxSchemaVersion from v1 param conversion
michael-valdron Mar 25, 2024
52de611
fix k8s.io/utils as direct dependency
michael-valdron Mar 25, 2024
bbd58c4
method not allowed query params removed
michael-valdron Mar 25, 2024
141dbd7
string pointer set check function
michael-valdron Mar 26, 2024
52e8060
minVersion & maxVersion filtering with range filtering & unit test fi…
michael-valdron Mar 26, 2024
51a0502
add missing schema version range filters to devfile endpoints
michael-valdron Mar 26, 2024
556d7de
remove fuzzy sets and punctuation removal
michael-valdron Mar 26, 2024
c467381
/v2index?minVersion=1.1&maxVersion=1.1 integration test cases added
michael-valdron Mar 26, 2024
3fa86ef
/index?provider=Red%22Hat&resources=.zip integrartion test case added
michael-valdron Mar 26, 2024
cf7ceb4
skip new test cases outside test registry
michael-valdron Mar 27, 2024
7343091
/index/sample?description=Hello%22World integration test case added
michael-valdron Mar 27, 2024
c901eb2
/index/all?description=node integration test case added
michael-valdron Mar 27, 2024
b54b59d
/v2index?name=java&default=true integration test case added
michael-valdron Mar 27, 2024
c0ea481
/v2index/sample?description=java&default=true integration test case a…
michael-valdron Mar 27, 2024
88a73d8
/v2index/all?description=java&default=true integration test case added
michael-valdron Mar 27, 2024
9474334
remove lazy eval from FilterResult
michael-valdron Mar 26, 2024
57b6967
remove unused MakeMockFilterResult
michael-valdron Mar 26, 2024
e07c8eb
AndFilter params by ref instead of by value
michael-valdron Mar 27, 2024
fd6c1ca
add deprecated query param
michael-valdron Apr 5, 2024
c0f41b3
add FilterDevfileDeprecated filter function and test cases
michael-valdron Apr 5, 2024
2f2b5ae
update test stacks to test against deprecated parameter
michael-valdron Apr 5, 2024
3664c47
update build index to filter based on deprecated stacks if deprecated…
michael-valdron Apr 5, 2024
5b6f1cf
integration test cases for deprecated filter parameter
michael-valdron Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index/server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,18 @@ require (
github.com/devfile/registry-support/index/generator v0.0.0
github.com/getkin/kin-openapi v0.117.0
github.com/gin-gonic/gin v1.9.0
github.com/hashicorp/go-set v0.1.13
github.com/hashicorp/go-version v1.4.0
github.com/kylelemons/godebug v0.0.0-20170820004349-d65d576e9348
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.1.0
github.com/prometheus/client_golang v1.14.0
golang.org/x/text v0.14.0
gopkg.in/segmentio/analytics-go.v3 v3.1.0
k8s.io/apiextensions-apiserver v0.26.10
k8s.io/apimachinery v0.26.10
k8s.io/utils v0.0.0-20230220204549-a5ecb0141aa5
oras.land/oras-go v1.2.5
)

Expand Down Expand Up @@ -96,7 +100,6 @@ require (
github.com/moby/locker v1.0.1 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/openshift/api v0.0.0-20200930075302-db52bc4ef99f // indirect
github.com/pelletier/go-toml/v2 v2.1.1 // indirect
Expand Down Expand Up @@ -143,12 +146,10 @@ require (
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/api v0.26.10 // indirect
k8s.io/apiextensions-apiserver v0.26.10 // indirect
k8s.io/client-go v0.26.10 // indirect
k8s.io/klog v1.0.0 // indirect
k8s.io/klog/v2 v2.90.1 // indirect
k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280 // indirect
k8s.io/utils v0.0.0-20230220204549-a5ecb0141aa5 // indirect
sigs.k8s.io/controller-runtime v0.14.7 // indirect
sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
Expand Down
3 changes: 3 additions & 0 deletions index/server/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,8 @@ github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY
github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
github.com/hashicorp/go-set v0.1.13 h1:k1B5goY3c7OKEzpK+gwAhJexxzAJwDN8kId8YvWrihA=
github.com/hashicorp/go-set v0.1.13/go.mod h1:0/D+R4MFUzJ6XmvjU7liXtznF1eQDxh84GJlhXw+lvo=
github.com/hashicorp/go-version v1.4.0 h1:aAQzgqIrRKRa7w75CKpbBxYsmUoPjzVm1W59ca1L0J4=
github.com/hashicorp/go-version v1.4.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
Expand Down Expand Up @@ -463,6 +465,7 @@ github.com/segmentio/backo-go v0.0.0-20200129164019-23eae7c10bd3 h1:ZuhckGJ10ula
github.com/segmentio/backo-go v0.0.0-20200129164019-23eae7c10bd3/go.mod h1:9/Rh6yILuLysoQnZ2oNooD2g7aBnvM7r/fNVxRNWfBc=
github.com/sergi/go-diff v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
github.com/shoenig/test v0.6.4 h1:kVTaSd7WLz5WZ2IaoM0RSzRsUD+m8wRR+5qvntpn4LU=
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6MwdIuYE2rE=
github.com/sirupsen/logrus v1.6.0/go.mod h1:7uNnSEd1DgxDLC74fIahvMZmmYsHGZGEOFrfsX/uA88=
Expand Down
Loading
Loading