Add Last Modified Field For Non-Versioned Items #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
What does does this PR do / why we need it:
This PR adds the logic for setting the
lastModified
field for stacks/samples that do not have a version. Before this change any samples that did not have a version had thelastModified
field set to the defaulttime.Time
value. This change allows for the dates to be set properly.You can reference the conversation around this issue here: #249 (comment)
This PR is flagged as WIP because I believe the changes made to
registry
here may need to be merged first for tests to pass as it contains changes to how thelast_modified.json
is generated during build.Which issue(s) this PR fixes:
Fixes devfile/api#1607
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
You should be able to test the following:
go test ./...
forindex/generator
passesgo test ./...
forindex/server
passesbash build_registry.sh
) and deploy it.Example of samples being set: