update go version in ci and dockerfiles #318
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Current changes looks good.
Some changes that needs addressing first before this can be merged:
- Along with updating the Go version in the dockerfiles you'll need to also unfreeze the references to
devfile-index-baseand index generator:- index generator - .ci/Dockerfile#L28: remove
-b v1.1.0from line and above comment about the freeze devfile-index-base- .ci/Dockerfile#38: revert tag back tonextand remove above comment about the freeze- index generator - .ci/Dockerfile.offline#L28: remove
-b v1.1.0from line and above comment about the freeze devfile-index-base- .ci/Dockerfile.offline#47: revert tag back tonextand remove above comment about the freeze
- index generator - .ci/Dockerfile#L28: remove
- Update golang tag reference under openshift/release to
golang-1.19(currently very oldgolang-1.16) and update the prow job withmake jobs
@michael-valdron would you like all of those to be included in this one PR? My initial thought was to have the different acceptance criteria for unfreezing and prow job updates to be separate PRs and that's why I left them out. If it's preferred to include all in this one I can do that :) |
@Jdubrick Unfreezing the references is part of the acceptance criteria for devfile/api#1473 and would be needed to ensure the Go version update allows the latest changes to work, prow job updates would be a separate PR however because it is under openshift/release. |
Signed-off-by: Jordan Dubrick <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
First of the PRs that will be opened in order to complete devfile/api#1473. This PR specifically updates the CI workflows and Dockerfiles to use
go 1.19. This PR also adds a badge to the readme that visually shows thatgo 1.19is being implemented.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1473
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
Building the registry works properly with
go 1.19and the workflows function.