Skip to content

Use odo nightly builds instead of 3.15.0 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Apr 22, 2024

What does this PR do?:

Simply updates the check_odo3.sh check to use the nightly builds of odo instead of 3.15.0

Which issue(s) this PR fixes:

fixes devfile/api#1415

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@thepetk thepetk requested a review from a team as a code owner April 22, 2024 14:05
@thepetk
Copy link
Contributor Author

thepetk commented Apr 22, 2024

I've temporary added a change to the go/2.3.0 stack to have 2 components using the same port number, something not supported in odo 3.15.0 but supported in the latest commit.

@thepetk
Copy link
Contributor Author

thepetk commented Apr 22, 2024

I've temporary added a change to the go/2.3.0 stack to have 2 components using the same port number, something not supported in odo 3.15.0 but supported in the latest commit.

Confirmed that the PR uses updated library here

@thepetk thepetk force-pushed the ft/update_odo_check branch from 81f96a2 to af1ce51 Compare April 22, 2024 15:15
@thepetk thepetk changed the title [DO NOT MERGE] Use odo nightly builds instead of 3.15.0 Use odo nightly builds instead of 3.15.0 Apr 22, 2024
@thepetk thepetk changed the title Use odo nightly builds instead of 3.15.0 [DO NOT MERGE] Use odo nightly builds instead of 3.15.0 Apr 26, 2024
@thepetk thepetk changed the title [DO NOT MERGE] Use odo nightly builds instead of 3.15.0 Use odo nightly builds instead of 3.15.0 Apr 26, 2024
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Just need to fix the DCO failure in some of the commits.

thepetk added 9 commits April 27, 2024 14:14
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
This reverts commit 2ad673e.

Signed-off-by: thepetk <[email protected]>
This reverts commit af1ce51.

Signed-off-by: thepetk <[email protected]>
@thepetk thepetk force-pushed the ft/update_odo_check branch from cee70ba to 20dcc8e Compare April 27, 2024 13:15
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 29, 2024
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 6dc67e6 into devfile:main Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike] Investigate usage of odo nightly builds for registry tests
2 participants