-
Notifications
You must be signed in to change notification settings - Fork 93
Use odo nightly builds instead of 3.15.0 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've temporary added a change to the |
Confirmed that the PR uses updated library here |
81f96a2
to
af1ce51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Just need to fix the DCO failure in some of the commits.
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
This reverts commit 2ad673e. Signed-off-by: thepetk <[email protected]>
This reverts commit af1ce51. Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
This reverts commit cc5099c. Signed-off-by: thepetk <[email protected]>
cee70ba
to
20dcc8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Simply updates the
check_odo3.sh
check to use the nightly builds of odo instead of 3.15.0Which issue(s) this PR fixes:
fixes devfile/api#1415
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: